An holl danevelloù
deus_displayed danevelloù bog
#104822: "Displayed score does not update for score over 6 points"
fixed: Kempennet eo bet ar bog
1
What is this report about?
Petra a zo c'hoarvezet ? Trugarez evit dibab amañ dindan
Bog diskweladur : titouroù-zo a zivout ar bartienn a oa gaou (hep heuliad grevus war disoc'h ar bartienn)
Deskrivadur dre ar munud
• Mar-plij, diskrivit kudenn an diskwel. M'ho peus un dapadenn skramm eus ar gudenn (ho pezit soñj d'eus se !), gellout a rit implij Imgur.com evit e bellgargañ hag eilañ/pegañ al liamm amañ.
The final score was correct (49) but the DISPLAYED score was 33.
imgur.com/IQ1OK33
I am pretty sure that what is happening is that if an individual line score is greater than can be displayed by icons (i.e. greater than six) then the individual line score is not added to the displayed score. Twice near the end of the game I scored 8 points for smaller Triumphal Arch (2 VP for 4 buildings) with four spaces with 4 buildings. That is twice 8 for a total of 16. The difference between the displayed score and the actual ending score is that same 16.
The actual ending score is correct. 5 VP to begin the game PLUS 45 VP during the game MINUS one VP stolen by LEGION.• Peseurt merdeer eo hoc'h hini ?
Google Chrome v119
Roll-istor an danevelloù bog
26. Du 2023 18:57 • MistakenIdentity • N'eo ket bet eiladet c'hoazh ar bog gant an diorroerien:
26. Du 2023 19:10 • MistakenIdentity • N'eo ket bet eiladet c'hoazh ar bog gant an diorroerien:
Here is a second instance of the same bug in 441761537
imgur.com/1VEEmEC
Same scenario. I scored 8 points for smaller Triumphal Arch (2 VP for 4 buildings) with four spaces with 4 buildings. The final score is 30 but the displayed score is 22
imgur.com/1VEEmEC
Same scenario. I scored 8 points for smaller Triumphal Arch (2 VP for 4 buildings) with four spaces with 4 buildings. The final score is 30 but the displayed score is 22
27. Du 2023 1:53 • robinzig • Kadarnaet eo bet ar bog gant an diorroerien:
Thanks - I've watched the replay and confirmed that I'm seeing the same incorrect behaviour as you.
It's clearly a very unusual situation to score more than 6VP from a civil card, which probably explains why no-one else has raised this in over 2 years - but it's still a bug!
I've taken a quick look at my code and in part you're spot on in your diagnosis - for the part where the VP tokens are animating as moving towards your player panel, that does indeed doesn't work properly (or at all) if more than 6VP is scored. Not sure how I missed that but should be easy to fix.
What is less obvious to me is why the actual score didn't update, as that's done in a separate function and it's not instantly obvious to me why that shouldn't work as intended. But I have tired eyes right now and am looking at code I mostly wrote over 2 years ago - now I have some idea what the issue is I hope I'll be able to reproduce it without too many problems.
Thanks again for raising this - I'm not sure when I'll have time to fix it but hopefully within a week or two.
It's clearly a very unusual situation to score more than 6VP from a civil card, which probably explains why no-one else has raised this in over 2 years - but it's still a bug!
I've taken a quick look at my code and in part you're spot on in your diagnosis - for the part where the VP tokens are animating as moving towards your player panel, that does indeed doesn't work properly (or at all) if more than 6VP is scored. Not sure how I missed that but should be easy to fix.
What is less obvious to me is why the actual score didn't update, as that's done in a separate function and it's not instantly obvious to me why that shouldn't work as intended. But I have tired eyes right now and am looking at code I mostly wrote over 2 years ago - now I have some idea what the issue is I hope I'll be able to reproduce it without too many problems.
Thanks again for raising this - I'm not sure when I'll have time to fix it but hopefully within a week or two.
23. Gen 2024 23:58 • robinzig • Kempennet eo bet ar bog:
Hello,
I'm so sorry this took a lot longer than I claimed - the Christmas holiday happened and then a few other things kept me busy, and meanwhile it was harder than I expected to set up this same scenario to test and observe what was happening. As soon as I did it was obvious what the problem was (which was exactly what I'd already said above - I just hadn't realised that my faulty code was actually throwing a JS error which made subsequent events, notably the updating of the VP, not happen), and easy to fix - so this should be fixed now.
Thanks again for the report!
I'm so sorry this took a lot longer than I claimed - the Christmas holiday happened and then a few other things kept me busy, and meanwhile it was harder than I expected to set up this same scenario to test and observe what was happening. As soon as I did it was obvious what the problem was (which was exactly what I'd already said above - I just hadn't realised that my faulty code was actually throwing a JS error which made subsequent events, notably the updating of the VP, not happen), and easy to fix - so this should be fixed now.
Thanks again for the report!
Ouzhpennañ un dra bennak d'an danevell-mañ
Ouzhpennit amañ mar-plij, tout ar pezh a c'hellfe bezañ talvoudus evit ma c'hellfemp dreveziñ ar bog-mañ pe kompren ho kinnig:
- Niverenn taol all / Niverenn ar fiñv
- Ha renket eo bet ar gudenn gant an douchenn F5 ?
- Ha c'hoarvezet eo ar gudenn meur a wech ? Bewech ? Cheñch-dicheñch ?
- M'ho peus un dapadenn skramm eus ar gudenn (ho pezit soñj d'eus se !), gellout a rit implij Imgur.com evit e bellgargañ hag eilañ/pegañ al liamm amañ.
